Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding support for jujutsu VCS inside find_workspace resolution #11685

Merged
merged 1 commit into from
Sep 21, 2024
Merged

adding support for jujutsu VCS inside find_workspace resolution #11685

merged 1 commit into from
Sep 21, 2024

Conversation

tdaron
Copy link
Contributor

@tdaron tdaron commented Sep 13, 2024

Hey !

This PR add support for detecting Jujutsu VCS repos as the workspace directory !

Hope it can be integrated into Helix :)

zetashift
zetashift approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@zetashift zetashift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, a small but helpful change for jujutsu users like me! Not a maintainer, but adding my review just in case.

@pascalkuthe
Copy link
Member

I am fine with this but I don't` really love that we have to keep hardcoding more things here whenever a new VCS pops up (usually anything but git is pretty niche)

@pascalkuthe pascalkuthe merged commit 896bf47 into helix-editor:master Sep 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetashift zetashift zetashift approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdaron @pascalkuthe @zetashift @the-mikedavis